Looks good to me, but you should have a reviewer from the client team as well. 

/Magnus

> 2 maj 2018 kl. 11:52 skrev Alexey Ivanov <alexey.iva...@oracle.com>:
> 
> Hi,
> 
> Could you please review the following fix for jdk11?
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8202476
> webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
> 
> This is a follow-up fix for JDK-8201226 which enabled building JDK for 32 bit 
> Windows, its code review: 
> http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021553.html
> 
> I found this issue:
> http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009150.html
> 
> 
> This fix removes JNICALL modifiers from exported functions in medialib.
> After the fix, the failing tests in test/jdk/java/awt/image pass.
> 
> 
> Thank you in advance.
> 
> Regards,
> Alexey

Reply via email to