Hi Igor,

It looks good.

Thanks,
Serguei


On 5/1/18 19:10, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,

could you please review the patch which open sources monitoring tests from vm 
testbase?

The tests were developed to test hotspot related JMX functionality. as w/ 
common VM testbase code, these tests are old, they have been run from hotspot 
testing for a long period of time. originally, these tests were run by a test 
harness different from jtreg and had different build and execution schemes, 
some parts couldn't be easily translated to jtreg, so tests might have actions 
or pieces of code which look weird. in a long term, we are planning to rework 
them.

JBS: https://bugs.openjdk.java.net/browse/JDK-8199375
webrev:  http://cr.openjdk.java.net/~iignatyev/8199375/webrev.00/index.html
testing: vmTestbase_nsk_monitoring test group

Thanks,
-- Igor

Reply via email to