Looks good to me. /Erik
On 2018-07-05 09:41, Severin Gehwolf wrote:
Hi, Please review this 8u-only change. JDK 10+ are not affected. For JDK 8 builds which don't perform any debug info stripping no .gnu_debuglink sections should get generated. The fix is to move the objcopy --add-gnu-debuglink calls into branches which actually perform some stripping: all_strip, min_strip. Thoughts? Bug: https://bugs.openjdk.java.net/browse/JDK-8206425 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8206425/webrev.01/ Testing: Manually produced a build with no stripping and verified no .gnu_debuglink sections got generated. $ for i in $(find build/linux-x86_64-normal-server-release/images/j2sdk-image/ \ | grep -E 'libjvm.so|libsaproc.so|libjsig.so'); do echo $i readelf --sections $i | grep gnu_debuglink; done build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjsig.so build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so Thanks, Severin
