On 6/07/2018 6:26 PM, Severin Gehwolf wrote:
Hi David,
On Fri, 2018-07-06 at 11:53 +1000, David Holmes wrote:
Hi Severin,
On 6/07/2018 2:41 AM, Severin Gehwolf wrote:
Hi,
Please review this 8u-only change. JDK 10+ are not affected.
For JDK 8 builds which don't perform any debug info stripping no
.gnu_debuglink sections should get generated. The fix is to move the
objcopy --add-gnu-debuglink calls into branches which actually perform
some stripping: all_strip, min_strip. Thoughts?
Has anything changed with the tools here? This has been in place since
back in 2011 with 7u2 and 8 GA! Why has it only become an issue now?
I'm doubtful anything has changed with the tools. This is one of those
patches which we seem to have been carrying downstream for a very long
time. My archeology seems to suggest it started to show up in Fedora 23
in November 2016. If anything, we'd be to blame to not push this fix
upstream earlier.
That's not an objection to the fix, I'm just curious how a problem could
exist for so long.
OK to get this pushed to JDK 8u?
You have your code reviews. Now you need to request approval as per:
http://openjdk.java.net/projects/jdk8u/approval-template.html
Cheers,
David
Thanks,
Severin
Thanks,
David
Bug: https://bugs.openjdk.java.net/browse/JDK-8206425
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8206425/webrev.01/
Testing: Manually produced a build with no stripping and verified no
.gnu_debuglink sections got generated.
$ for i in $(find build/linux-x86_64-normal-server-release/images/j2sdk-image/ \
| grep -E 'libjvm.so|libsaproc.so|libjsig.so'); do echo $i
readelf --sections $i | grep gnu_debuglink; done
build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/libjsig.so
build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/libsaproc.so
build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjsig.so
build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64/server/libjvm.so
Thanks,
Severin
