Hi,

In our downstream build, I'd like to be able to set/customize the value for the 
Windows RC properties "ProductName" and "FileDescription" via the 
version-numbers file. These values manifest in Windows executable properties.

During the build ProductName gets set to "OpenJDK Platform 13" and 
FileDescription will be "OpenJDK Platform binary". This value is obtained by 
concatenating \$(PRODUCT_NAME) \$(JDK_RC_PLATFORM_NAME) in flags-other.m4. Both 
variables get set in version-numbers. So, if I was to customize the properties, 
I could change PRODUCT_NAME and JDK_RC_PLATFORM_NAME in version-numbers. 
However, modifying the former is no good idea since it is used ubiquitously and 
has unwanted side effects. On the other hand, I could make an adaption to 
flags-other.m4, but that diff would be hidden and not in a central place where 
I'd expect such customizing diffs.

So, please review this small fix, which allows for modifying these RC 
properties in version-numbers. The default behavior won't be changed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8221880
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8221880.0/

Thanks
Christoph

Reply via email to