On 2019-04-04 07:15, Langer, Christoph wrote:
Hello Erik,
In OpenJDK builds, the current strings evaluate to "OpenJDK Platform"
and for Oracle builds "Java(TM) Platform SE". It makes me curious as to
what you need to modify the string to?
We want to print "SapMachine" there, see this commit:
https://github.com/SAP/SapMachine/commit/e70a2bcb8a813bfca7adf82590
a4427114af88a6#diff-00a92a44400757c2a70383c1b51ab8fa
I would also be beneficial, if we could add a configure option for
MACOSX_BUNDLE_NAME_BASE and MACOSX_BUNDLE_ID_BASE. We have
a diff there as well:
https://github.com/SAP/SapMachine/commit/d5df3b2c65fd8b833989375886
640433ee9fa0f1#diff-ac0146eb7428c83f99766e2a13ff1b17
This makes me wonder why you don't also want to change the
PRODUCT_NAME
to SapMachine. Wouldn't it make more sense to have it all match? Or are
you worried about compatibility issues if users expect the value
OpenJDK? At least Oracle and OpenJDK builds have different values there
already.
Yes, we are worried about compatibility issues. It starts with (jtreg) tests
that would fail. To that we could make adaptions, of course. But looking around
all other downstream vendors stick with OpenJDK so far. So, no reason why we
should go this route first 😉
Or are there maybe other hooks to customize these kinds of properties?
No other hooks that I know of. If you need customization, please add
configure parameters. We haven't added any only because nobody has
needed such customization yet.
Ok, I'll see if I come up with configuration parameters for the Mac properties.
But I'll do it in a different change.
In any case, if it comes to a push of this change, I'd then let you do it to
coordinate with your internal infrastructure 😊
OK, I can do that if needed, but if we find a solution where it's not,
I'm happy to let you push yourself. :)
Good. Then we are back at my latest webrev:
http://cr.openjdk.java.net/~clanger/webrevs/8221880.1/
Ah, right, this change does not remove JDK_RC_PLATFORM_NAME from
version-numbers, but it does remove it from spec.gmk.in. Could you leave
it in spec.gmk.in? Then you can commit this at your own time.
/Erik
Anything you want me to change? Otherwise, please do your preparations and let
me know when and how this is going to be committed 😊
Thanks
Christoph
