On 22/10/2019 04:22, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
I've read through the code for the new jlink plugins and the changes to
VersionProps and it looks good.
An alternative for VersionProps would have been to generate a helper
class at link time rather than extending the static initilizer to set
the fields. That would allow the VENDOR* fields to be final (but I don't
think it makes too much difference and it may be a bit more complicated
due to having 4 plugins contributing code).
The need for a plugin per CLI option may be motivation to explore (in
the future) having a single plugin expose multiple options.
-Alan
