Nice to see this finally happen.
In GensrcCharsetMapping.gmk you are adding a new line for declaring dep
on $(BUILD_TOOLS_JDK) without removing that dep from the original rule
declaration. Same in GensrcEmojiData.gmk. Not sure what the intention is.
Otherwise good.
/Erik
On 2020-05-19 05:52, Magnus Ihse Bursie wrote:
All other phases are using ModuleWrapper.gmk, except for gensrc. We
should move that too over to the ModuleWrapper way, so all phases are
treated equally.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245287
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8245287-use-ModuleWrapper-for-gensrc/webrev.01
/Magnus
