On 2020-05-19 15:19, Erik Joelsson wrote:
Nice to see this finally happen.
In GensrcCharsetMapping.gmk you are adding a new line for declaring
dep on $(BUILD_TOOLS_JDK) without removing that dep from the original
rule declaration. Same in GensrcEmojiData.gmk. Not sure what the
intention is.
The intention was to try to fix what I thought was a dependency bug, but
which just was too unlikely to show up. The rest of the GensrcFoo files
had an explicit, separate dependency declaration to the buildtools, like
this. Since it was missing, I assumed it was a mistake, and did not
double check to see if it was given as a dependency elsewhere.
I removed those two lines before pushing.
Otherwise good.
Thanks.
/Magnus
/Erik
On 2020-05-19 05:52, Magnus Ihse Bursie wrote:
All other phases are using ModuleWrapper.gmk, except for gensrc. We
should move that too over to the ModuleWrapper way, so all phases are
treated equally.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245287
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8245287-use-ModuleWrapper-for-gensrc/webrev.01
/Magnus
