On Mon, 26 Oct 2020 08:11:47 GMT, Robin Westberg <rwestb...@openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Remove duplicate PATH item
>>    
>>    Co-authored-by: Robin Westberg <ro...@westberg.se>
>>  - Remove duplicate PATH item
>>    
>>    Co-authored-by: Robin Westberg <ro...@westberg.se>
>
> Looks good! I also tried including the entire test-support folder at some 
> point, but as you noticed it takes quite a bit of time and space. So this 
> approach seems much better.
> 
> Minor comment: The cygwin\bin folder is included twice in PATH on Windows to 
> work around a bug in JTReg (the regex used to detect cygwin does not match 
> the very first entry in the PATH list. Perhaps I should file a bug for 
> that..) but it's not really needed if you are executing something else.

Thanks! I have not even noticed there is double item in `PATH`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/842

Reply via email to