On Mon, 26 Oct 2020 08:22:47 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Currently, we are only archiving `build/*/test-results`. But hs_errs, >> replays, and test outputs are actually in `build/*/test-support`! Which >> means once any test fails, we only have the summary of the run, not the bits >> that would actually help to diagnose the problem. >> >> Archiving the entire test-support seems too much, it yields 50K artifacts >> available as 1 GB zip archive in GH GUI. On top of that `upload-artifact` >> does the upload per-file, which takes tens of minutes on 50K files (and I >> suspect many API calls). >> >> But we can pick up important test outputs selectively and then also compress >> them. See sample artifact here: >> https://github.com/shipilev/jdk/runs/1301540541 >> >> It packages the final ZIP like this: >> >> $ unzip -t test-results_.zip >> Archive: test-results_.zip >> testing: artifact/ OK >> testing: artifact/linux-x64-debug_testresults_hs_tier1_common.zip OK >> testing: artifact/linux-x64-debug_testsupport_hs_tier1_common.zip OK >> ... > > Aleksey Shipilev has updated the pull request incrementally with two > additional commits since the last revision: > > - Remove duplicate PATH item > > Co-authored-by: Robin Westberg <ro...@westberg.se> > - Remove duplicate PATH item > > Co-authored-by: Robin Westberg <ro...@westberg.se> Looks good to me. ------------- Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/842
