On Wed, 11 Nov 2020 09:02:27 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> Update the docs with the (f)actual recipe used in JDK-8256127. Thanks for keeping the documentation up to date! I have no objection to the actual content, just these minor formatting comments. doc/building.md line 1100: > 1098: > --include=fakeroot,symlinks,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxrandr-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng-dev > \ > 1099: --resolve-deps \ > 1100: buster \ I'm guessing `--resolve-deps buster` is the full option; if so, it should be on a single line, otherwise it reads very strange. doc/building.md line 1107: > 1105: * Make sure the symlinks inside the newly created chroot point to > proper locations: > 1106: > 1107: ``` I think it is important that you do not have an empty line between the bullet line and the code block, to get nicely formatted html. I know markdown is typically fiddly in such cases, and I notice that this is how the other bullets are written. ------------- Changes requested by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1160
