On Wed, 11 Nov 2020 11:39:56 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove newline before code block > > doc/building.md line 1100: > >> 1098: >> --include=fakeroot,symlinks,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxrandr-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype6-dev,libpng-dev >> \ >> 1099: --resolve-deps \ >> 1100: buster \ > > I'm guessing `--resolve-deps buster` is the full option; if so, it should be > on a single line, otherwise it reads very strange. Not really: `buster` is the `SUITE`, it is the argument on its own. > doc/building.md line 1107: > >> 1105: * Make sure the symlinks inside the newly created chroot point to >> proper locations: >> 1106: >> 1107: ``` > > I think it is important that you do not have an empty line between the bullet > line and the code block, to get nicely formatted html. I know markdown is > typically fiddly in such cases, and I notice that this is how the other > bullets are written. Right! Fixed that. ------------- PR: https://git.openjdk.java.net/jdk/pull/1160
