On Thu, 19 Nov 2020 12:36:46 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> @kimbarrett >> Okay, thank you for explanation. >> I agree, it'd make sense to improve the comment a little bit. >> Thanks, >> Serguei > > So should nsk_jvmti_aod_disableEventAndFinish pass the address of success > instead? Why didn't it fail before this change? > Ok, with this change, it's not posted yet and the success variable for > nsk_aod_agentFinished is the local variable. We should fix this in an RFE > filed: https://bugs.openjdk.java.net/browse/JDK-8256651 /* Flush any pending ObjectFree events, which will set global success variable to 1 for any pending ObjectFree events. */ How about this? The word 'global' helps me. ------------- PR: https://git.openjdk.java.net/jdk/pull/967
