On Thu, 19 Nov 2020 12:51:11 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> So should nsk_jvmti_aod_disableEventAndFinish pass the address of success >> instead? Why didn't it fail before this change? >> Ok, with this change, it's not posted yet and the success variable for >> nsk_aod_agentFinished is the local variable. We should fix this in an RFE >> filed: https://bugs.openjdk.java.net/browse/JDK-8256651 > > /* Flush any pending ObjectFree events, which will set global success > variable to 1 > for any pending ObjectFree events. */ > How about this? The word 'global' helps me. With remerging into shenandoah, all the jdi tests pass with shenandoah also. ------------- PR: https://git.openjdk.java.net/jdk/pull/967
