On Fri, 20 Nov 2020 16:14:19 GMT, Robin Westberg <[email protected]> wrote:
>> Currently Linux x64 testing in GitHub Actions depends on a few non-relevant
>> hotspot build-only jobs (such as zero) that prevents testing from being run
>> if those build were to fail. As the tests only require the x64 release and
>> debug builds to run and provide interesting feedback, we should separate
>> these other builds into a different job.
>>
>> To reduce duplicated steps, all the existing hotspot-only builds have been
>> consolidated into a single job.
>
> Robin Westberg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improve naming, fix style issues
Looks good! A few minor nits, if you want to address them.
.github/workflows/submit.yml line 526:
> 524: echo "CC=${{ matrix.gnu-arch }}-linux-gnu${{
> matrix.gnu-flavor}}-gcc-10" >> $GITHUB_ENV
> 525: echo "CXX=${{ matrix.gnu-arch }}-linux-gnu${{
> matrix.gnu-flavor}}-g++-10" >> $GITHUB_ENV
> 526: echo "cross_flags=--openjdk-target=${{ matrix.gnu-arch
> }}-linux-gnu${{ matrix.gnu-flavor}} --with-sysroot=${HOME}/sysroot-${{
> matrix.debian-arch }}/ --with-toolchain-path=${HOME}/sysroot-${{
> matrix.debian-arch }}/ --with-freetype-lib=${HOME}/sysroot-${{
> matrix.debian-arch }}/usr/lib/${{ matrix.gnu-arch }}-linux-gnu${{
> matrix.gnu-flavor}}/ --with-freetype-include=${HOME}/sysroot-${{
> matrix.debian-arch }}/usr/include/freetype2/
> --x-libraries=${HOME}/sysroot-${{ matrix.debian-arch }}/usr/lib/${{
> matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}/" >> $GITHUB_ENV
No chance to break this line by option? It is kinda hard to read and thus
verify. It is still okay if we cannot.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1350
