On Fri, 20 Nov 2020 17:31:08 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Robin Westberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve naming, fix style issues
>
> .github/workflows/submit.yml line 526:
>
>> 524: echo "CC=${{ matrix.gnu-arch }}-linux-gnu${{
>> matrix.gnu-flavor}}-gcc-10" >> $GITHUB_ENV
>> 525: echo "CXX=${{ matrix.gnu-arch }}-linux-gnu${{
>> matrix.gnu-flavor}}-g++-10" >> $GITHUB_ENV
>> 526: echo "cross_flags=--openjdk-target=${{ matrix.gnu-arch
>> }}-linux-gnu${{ matrix.gnu-flavor}} --with-sysroot=${HOME}/sysroot-${{
>> matrix.debian-arch }}/ --with-toolchain-path=${HOME}/sysroot-${{
>> matrix.debian-arch }}/ --with-freetype-lib=${HOME}/sysroot-${{
>> matrix.debian-arch }}/usr/lib/${{ matrix.gnu-arch }}-linux-gnu${{
>> matrix.gnu-flavor}}/ --with-freetype-include=${HOME}/sysroot-${{
>> matrix.debian-arch }}/usr/include/freetype2/
>> --x-libraries=${HOME}/sysroot-${{ matrix.debian-arch }}/usr/lib/${{
>> matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}/" >> $GITHUB_ENV
>
> No chance to break this line by option? It is kinda hard to read and thus
> verify. It is still okay if we cannot.
Sure, I agree, perhaps just putting that as a separate step would increase
readability.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1350
