> Right now `CompileJavaModules.gmk` contains two different part: one part with > the functionality needed to compile a java module, and one part were all > special requirements for all modules are listed. > > The second part should be removed from `CompileJavaModules.gmk`, and instead > listed directly for each individual module in `make/modules/$M/Java.gmk`. > > I used a special-written shell script to automatically extract the > module-specific part from CompileJavaModules.gmk into the respective Java.gmk > files, to avoid risking any hard-to-detect copy/paste errors. After this I > did a `sed -i` to remove the module-specific prefix. All this makes me > confident that I have correctly moved the variables (I realize this is hard > to verify from the patch).
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Rename DISABLED_WARNINGS to DISABLED_WARNINGS_java to avoid overwriting the global variable ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/1779/files - new: https://git.openjdk.java.net/jdk/pull/1779/files/09b5bee7..1e1cb858 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1779&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1779&range=00-01 Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/1779.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1779/head:pull/1779 PR: https://git.openjdk.java.net/jdk/pull/1779
