On Tue, 15 Dec 2020 14:40:34 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Right now `CompileJavaModules.gmk` contains two different part: one part >> with the functionality needed to compile a java module, and one part were >> all special requirements for all modules are listed. >> >> The second part should be removed from `CompileJavaModules.gmk`, and instead >> listed directly for each individual module in `make/modules/$M/Java.gmk`. >> >> I used a special-written shell script to automatically extract the >> module-specific part from CompileJavaModules.gmk into the respective >> Java.gmk files, to avoid risking any hard-to-detect copy/paste errors. After >> this I did a `sed -i` to remove the module-specific prefix. All this makes >> me confident that I have correctly moved the variables (I realize this is >> hard to verify from the patch). > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Final bug fixes... Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/1779
