On Tue, 15 Dec 2020 20:27:36 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> This looks better but I think we need to find better names for the conf
>> files. Prefixing them with "module-sets" looks really strange.
>> JRE_TOOL_MODULES in module-sets-classloaders.conf might also need to be
>> re-examined because it is not used to generate ModuleLoaderMap. Instead it
>> was defined in Modules.gmk for the legacy-jre-image build target.
>
> I thought it was a consistent and clear naming scheme. :-) But I guess to
> each their own...
>
> Would `classloader-modules.conf`, `docs-modules.conf` and `build-modules.con`
> be better? Otherwise you'll need to come up with any better solutions
> yourself, since I'm starting to run out of ideas.
As for `JRE_TOOL_MODULES`, I understand what you mean but it is at least kind
of a "sibling" to the others. After all, we use these sets of modules together
to form the set of modules for the JRE:
JRE_MODULES += $(filter $(ALL_MODULES), $(BOOT_MODULES) \
$(PLATFORM_MODULES) $(JRE_TOOL_MODULES))
So given that `BOOT_MODULES` and `PLATFORM_MODULE` has a role to play here as
well, I think it would be odd *not* to have `JRE_TOOL_MODULES` defined at the
same place.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1781
