On Fri, 25 Dec 2020 11:44:11 GMT, Jie Fu <ji...@openjdk.org> wrote: > Maybe, the title would be better with 'Zero: non-PCH release build fails > after JDK-8258074'.
Hi Jie, thanks for your comment. Yes. Agree. It's much more accurate to describe this issue with 'release' added. Will rename it next Monday as I need ask my colleague to help me rename the title of the corresponding JBS issue (since I'm not a JDK author currently). > > Just wondering why it gets passed with debug build? > Thanks. Regarding the debug build, I guess it's because that flag 'pd_CICompileOSR' is not used for debug build. Please refer to https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/globals_shared.hpp#L84 I suppose macro 'DECLARE_PD_DEVELOPER_FLAG' is defined at line 86 for release build where flags 'pd_XXX' would be used, while this macro is defined at line 90 for debug build where flags 'pd_XXX' are not used. Please let me know if I misunderstand anything since I'm a beginner on OpenJDK. Thanks. :) ------------- PR: https://git.openjdk.java.net/jdk/pull/1894
