On Mon, 4 Jan 2021 10:09:23 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> It is unclear to me why the original change in JDK-8258074 included > `compiler_globals_pd.hpp` in `globals.hpp` at all, @iklam? The reason is, for historical reasons, some PD flags related to the compiler, such as `BackgroundCompilation`, are declared in `globals.hpp`. As a result, `globals.hpp` must include `compiler_globals_pd.hpp`, which provides the platform-specific default value for `BackgroundCompilation`. This should eventually be fixed by moving the declaration of these flags to compiler_globals.hpp instead. > I believe we should additionally change the `#include > compiler/compiler_globals_pd.hpp` to `#include compiler/compiler_globals.hpp` > in `globals.hpp`? This is not necessary. `globals.hpp` does not use anything declared in `compiler_globals.hpp` ------------- PR: https://git.openjdk.java.net/jdk/pull/1894
