On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi <mi...@openjdk.org> wrote:

>> Hi, Please review
>> systemDictionaryShared becomes fatter and fatter so it is time to split it 
>> into functional files. Moved security and jar operation related code into 
>> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to 
>> sharedClassInfo.[ch]pp, also moved lambda proxy related to 
>> lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and 
>> light.
>> 
>> Tests: tier1,tier3,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove 'Shared' from class names and rename corresponding files

Latest changes look good. One question.

src/hotspot/share/cds/lambdaProxyClassDictionary.hpp line 28:

> 26: #define SHARED_CDS_LAMBDAPROXYCLASSINFO_HPP
> 27: #include "cds/metaspaceShared.hpp"
> 28: #include "classfile/javaClasses.hpp"

Is this include necessary?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4568

Reply via email to