On Mon, 28 Jun 2021 23:13:24 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove 'Shared' from class names and rename corresponding files
>
> This looks OK to me.
> 
> The naming of the various classes is still not consistent since the code has 
> evolved for a long time. It was probably a mistake to add `Shared` as a 
> classname suffix, but that was done since the beginning of CDS.
> 
> Maybe eventually we should rename all the classes with a CDS prefix (similar 
> to the JFR code). That should be done in a separate PR, though.

@iklam @calvinccheung @erikj79 
Thank you for review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4568

Reply via email to