> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build 
> system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
> 
> Hsdis.gmk has two problems:
> 
> 1. MinGW version is fixed to "9.2.0"
> 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/sys-root
> 
> I tested this change on WSL only, so it is appreciate to review on Cygwin.

Yasumasa Suenaga has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains four additional 
commits since the last revision:

 - Merge remote-tracking branch 'magicus/hsdis-on-wsl' into JDK-8276672
 - Make hsdis building on Windows more general
 - Merge remote-tracking branch 'upstream/master' into JDK-8276672
 - 8276672: Cannot build hsdis on WSL

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6269/files
  - new: https://git.openjdk.java.net/jdk/pull/6269/files/ea5e749b..7fa765cd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6269&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6269&range=00-01

  Stats: 397648 lines in 435 files changed: 195125 ins; 194851 del; 7672 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6269.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6269/head:pull/6269

PR: https://git.openjdk.java.net/jdk/pull/6269

Reply via email to