On Wed, 10 Nov 2021 00:55:13 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal >> build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from >> Ubuntu. >> >> Hsdis.gmk has two problems: >> >> 1. MinGW version is fixed to "9.2.0" >> 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/sys-root >> >> I tested this change on WSL only, so it is appreciate to review on Cygwin. > > Yasumasa Suenaga has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge remote-tracking branch 'magicus/hsdis-on-wsl' into JDK-8276672 > - Make hsdis building on Windows more general > - Merge remote-tracking branch 'upstream/master' into JDK-8276672 > - 8276672: Cannot build hsdis on WSL I removed `SYSROOT_FLAGS` because it is no longer used. ------------- PR: https://git.openjdk.java.net/jdk/pull/6269