On Mon, 15 Nov 2021 13:44:11 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in >> macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set >> any deployment target when when we use xcrun to create .air file and this >> issue looks similar to https://developer.apple.com/forums/thread/105719. >> Also https://developer.apple.com/forums/thread/105719 states that even if >> they set app deployment target they need to explicitly set deployment in >> "xcrun metal". >> >> Made same change to use -mmacosx-version-min=10.12.00 in our make file. >> Whether we should keep 10.12.00 or 10.13/14 is open to discussion for metal >> pipeline. >> >> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) >> has confirmed that patch resolves the issue. > > Jayathirth D V has updated the pull request incrementally with one additional > commit since the last revision: > > Use 10.14 macOS version make/modules/java.desktop/lib/Awt2dLibraries.gmk line 844: > 842: # for aarch64 is 11.00.00 at the time of introducing > MACOSX_METAL_VERSION_MIN. > 843: ifeq ($(OPENJDK_TARGET_CPU_ARCH), xaarch64) > 844: MACOSX_METAL_VERSION_MIN=11.00.00 I like Erik's suggestion of using `MACOSX_VERSION_MIN` for `aarch64`, since it's one less place you need to duplicate a constant. ------------- PR: https://git.openjdk.java.net/jdk/pull/6346
