On Mon, 15 Nov 2021 13:46:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use 10.14 macOS version > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 844: > >> 842: # for aarch64 is 11.00.00 at the time of introducing >> MACOSX_METAL_VERSION_MIN. >> 843: ifeq ($(OPENJDK_TARGET_CPU_ARCH), xaarch64) >> 844: MACOSX_METAL_VERSION_MIN=11.00.00 > > I like Erik's suggestion of using `MACOSX_VERSION_MIN` for `aarch64`, since > it's one less place you need to duplicate a constant. Hi Kevin, I noticed the comment after pushing the change. I have updated it. Thanks, Jay ------------- PR: https://git.openjdk.java.net/jdk/pull/6346