On Fri, 17 Dec 2021 17:47:02 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with three 
>> additional commits since the last revision:
>> 
>>  - 8278766: Enable OpenJDK build support for reproducible jars and jmods 
>> using --date
>>    
>>    Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>>  - 8278766: Enable OpenJDK build support for reproducible jars and jmods 
>> using --date
>>    
>>    Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>>  - 8278766: Enable OpenJDK build support for reproducible jars and jmods 
>> using --date
>>    
>>    Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> make/common/JarArchive.gmk line 234:
> 
>> 232:     endif
>> 233:   else
>> 234:     $1_JAR_OPTIONS := $$($1_JAR_SOURCE_DATE)
> 
> Instead of adding $$($1_JAR_SOURCE_DATE) to every branch of this conditional, 
> you can use += to build the $1_JAR_OPTIONS variable one step at a time. I 
> don't think we need a separate variable JAR_SOURCE_DATE.

reduced as stated

-------------

PR: https://git.openjdk.java.net/jdk/pull/6878

Reply via email to