On Wed, 22 Dec 2021 13:41:53 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > make/InitSupport.gmk line 317: > >> 315: export SOURCE_DATE_EPOCH := $$(SOURCE_DATE) >> 316: ifeq ($$(IS_GNU_DATE), yes) >> 317: SOURCE_DATE_ISO_8601 := $(shell $(DATE) --utc >> --date="@$(SOURCE_DATE_EPOCH)" +"%Y-%m-%dT%H:%M:%SZ" 2> /dev/null) > > Are you getting this to work without `export`? I would have expected that to > be needed. @erikj79 right, so I was using the wrong configuration and reproducible-build was not set, now I am, I can see I am where I was before in that SOURCE_DATE_ISO_8601 being set in InitSupport.gmk is not visible in JarArchive.gmk, i've tried both with and without the export...? ------------- PR: https://git.openjdk.java.net/jdk/pull/6878
