On Wed, 22 Dec 2021 15:44:39 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > Andrew Leonard has updated the pull request incrementally with three > additional commits since the last revision: > > - 8278766: Enable OpenJDK build support for reproducible jars and jmods > using --date > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - 8278766: Enable OpenJDK build support for reproducible jars and jmods > using --date > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> > - 8278766: Enable OpenJDK build support for reproducible jars and jmods > using --date > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> make/InitSupport.gmk line 320: > 318: else > 319: export SOURCE_DATE_ISO_8601 := $$(shell $$(DATE) -u -j -f "%s" > "$$(SOURCE_DATE_EPOCH)" +"%Y-%m-%dT%H:%M:%SZ" 2> /dev/null) > 320: endif This is starting to look pretty good, but I would ask you to try to break these long lines. We try to keep the makefiles reasonably narrow for easier future 3-way merges and diff viewing. ------------- PR: https://git.openjdk.java.net/jdk/pull/6878
