On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker <d...@openjdk.java.net> wrote:
> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) > was merged in 16, MSys 2 became capable of building a functional JDK on > Windows. This PR updates some outdated documentation in building.html and > building.md to reflect that change. > > I appreciate any reviews, and would like to know how I might be able to > improve the wording of both updated docs, if possible. @TheShermanTanker Some comments in no particular order. * The MSYS2 project calls themselves "MSYS2"; I think it'd be proper to reflect this capitalization/lack of space before the 2. * This PR has technical problems. You are trying to reuse the old JBS bug issue. You'll need a new bug entry for the problem you are trying to solve here. If you do not have access to the bug system, let me know and I can help you. * I have actually a similar fix on a personal branch, where I'm updating several omissions in the build README. However, when I went to try building on an MSYS2 installation with the mainline head, it actually failed.. :-( Have you successfully built on MSYS2 with the mainline JDK? ------------- PR: https://git.openjdk.java.net/jdk/pull/7242
