On Thu, 27 Jan 2022 14:37:51 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> The updated wording seems fine to me. > > The html file should not be edited by hand, but generated (by pandoc) using > the make target `update-build-docs`. If you don't have access to pandoc, I > can help you regenerate the file. > > It looks like you are trying to reuse an existing and already resolved BugID > for this change. That is not possible. A new bug must be filed for each > change in OpenJDK. @erikj79 I don't have access to pandoc, would be appreciated if you could help me out with that! > @TheShermanTanker Some comments in no particular order. > > * The MSYS2 project calls themselves "MSYS2"; I think it'd be proper to > reflect this capitalization/lack of space before the 2. > * This PR has technical problems. You are trying to reuse the old JBS bug > issue. You'll need a new bug entry for the problem you are trying to solve > here. If you do not have access to the bug system, let me know and I can help > you. > * I have actually a similar fix on a personal branch, where I'm updating > several omissions in the build README. However, when I went to try building > on an MSYS2 installation with the mainline head, it actually failed.. :-( > Have you successfully built on MSYS2 with the mainline JDK? @magicus -Noted, will update the PR to reflect that soon -I don't have access to the bug system unfortunately, would be great if you could help me file a new one. How do I get access to it for any future PRs? -Yep, I initially used it since i did want to try building the JDK with gcc, but then found out gcc wasn't supported on Windows, but building it with the default MSVC worked well. Odd that it didn't work for you though, what was the failure? ------------- PR: https://git.openjdk.java.net/jdk/pull/7242
