On Tue, 7 Jun 2022 13:26:52 GMT, Leo Korinth <lkori...@openjdk.org> wrote:
>> make/RunTests.gmk line 47: >> >>> 45: define IfPrepend >>> 46: $(if $(strip $1),$(strip $2)$(strip $1),) >>> 47: endef >> >> These two probably fits better in make/common/Utils.gmk. >> >> Also please have a look at the [Code Conventions for the Build >> System](http://openjdk.java.net/groups/build/doc/code-conventions.html). One >> liner macros like this we like to format like this: >> >> >> IfPrepend = \ >> $(if $(strip $1),$(strip $2)$(strip $1),) > > I moved them both to `make/common/Utils.gmk`. (and made them one-liners, but with indentation four to match the code around) ------------- PR: https://git.openjdk.java.net/jdk/pull/9028
