On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth <lkori...@openjdk.org> wrote:
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly > yet, I wanted to show the code to get feedback first. The idea is to *not* > emulated destructive imperative assignments through the use of eval. I > instead try to handle it in a functional style without reassigning variables. > I have tried to make the change as small as possible. > > I am not used to change the build system, so I would appreciate thorough > review. > > `IfAppend` and `IfPrepend` are general purpose functions. If similar > functions exists elsewhere inside the code base or in make itself I should > probably use those instead. If they do not exist, they might be useful > elsewhere and maybe should be placed in a common make file instead of the > RunTests.gmk file. `#` is treated as a comment by make itself. And the make file is using `eval` to set variables. Thus the test case selection will be regarded as comment (and stripped). ------------- PR: https://git.openjdk.java.net/jdk/pull/9028
