On Tue, 7 Jun 2022 17:48:30 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 357: > >> 355: $(subst .java,,$(subst .java,,$(suffix $(notdir $1)))) >> 356: >> 357: # The test selector starting with a hash (#testid) will be stripped by >> all > > Small nit - I think "selection" and "test selector" in the comments should be > changed to "test id" so you don't call the same thing with 3 different names. > But otherwise the change looks good to me.
I agree. ------------- PR: https://git.openjdk.java.net/jdk/pull/9028
