On Tue, 23 Aug 2022 11:29:45 GMT, Sacha Coppey <d...@openjdk.org> wrote:

>> This patch adds a partial JVMCI implementation for RISC-V, to allow using 
>> the GraalVM Native Image RISC-V LLVM backend, which does not use JVMCI for 
>> code emission.
>> It creates the jdk.vm.ci.riscv64 and jdk.vm.ci.hotspot.riscv64 packages, as 
>> well as implements a part of jvmciCodeInstaller_riscv64.cpp. To check for 
>> correctness, it enables JVMCI code installation tests on RISC-V. More 
>> testing is performed in Native Image.
>
> Sacha Coppey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix error when emitting LUI and removed vector registers

This has passed jtreg tests under test/hotspot/jtreg/compiler/jvmci with your 
updated changes.
Do you have details about testing performed in Native Image as mentioned in PR 
decription?

I see you added more changes in hotspot file sharedRuntime_riscv.cpp guarded by 
macro INCLUDE_JVMCI.
Searching for INCLUDE_JVMCI or COMPILER2_OR_JVMCI in src/hotspot/cpu/aarch64, I 
see several more places
checking for these macros. Have you checked if we need similar changes for your 
use case?

Also could you explain the change made in hotspot file deoptimization.hpp? 
Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/9587

Reply via email to