On Wed, 24 Aug 2022 07:43:06 GMT, Sacha Coppey <d...@openjdk.org> wrote:
> > I see you added more changes in hotspot file sharedRuntime_riscv.cpp > > guarded by macro INCLUDE_JVMCI. Searching for INCLUDE_JVMCI or > > COMPILER2_OR_JVMCI in src/hotspot/cpu/aarch64, I see several more places > > checking for these macros. Have you checked if we need similar changes for > > your use case? > > I first added the changes for all places where those macros are used, but > since only modifying sharedRuntime_riscv.cpp was enough to make the tests > pass, I did not wanted to add code that I was not sure was useful at the > moment. Well, that sounds fragile to me since you are depending on a relatively small set of JTreg tests here. I think an analysis is needed here to be sure about whether those are really needed or not. ------------- PR: https://git.openjdk.org/jdk/pull/9587
