On Mon, 24 Oct 2022 20:06:58 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix styleheet > > make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 86: > >> 84: >> 85: ModuleElement module = >> docletEnvironment.getElementUtils().getModuleOf(element); >> 86: File dotFile = new File(sealedGraphDotPath, > > These days, it is preferable to use NIO, so use `Path` instead of `File`. Fixed. > make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 93: > >> 91: .map(ModuleElement.ExportsDirective.class::cast) >> 92: // Only include packages that are globally exported >> (i.e. no "to" exports) >> 93: .filter(me -> me.getTargetModules() == null) > > The lambda parameter here is an `ExportsDirective`, not a `ModuleElement`, > suggesting that the name here should be `ed` instead of `me`. Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/10761
