On Tue, 6 Dec 2022 19:20:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> CHECK_VALUE > > make/autoconf/jdk-version.m4 line 78: > >> 76: UTIL_ARG_WITH(NAME: build-user, TYPE: string, >> 77: RESULT: USERNAME, >> 78: DEFAULT: [ `$ECHO "$USER" | $TR -d -c '[a-z][A-Z][0-9]'` ], > > Can you move this outside the UTIL_ARG_WITH block and assign it to a > variable? I'm worried this might be evaluated multiple times otherwise. > > Also, I know this was not present before, but please add something along the > lines of: > `DEFAULT_DESC: [current username, sanitized]` Will do, thanks ------------- PR: https://git.openjdk.org/jdk/pull/11020
