On Thu, 15 Dec 2022 14:15:29 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options that still use AC_ARG_WITH in jdk-version.m4. >> They are out of the scope of this commit, which aims only to rework the >> previous integrated commits mentioned above. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Unbreak GHA Guess this really is going to need some fixing after all (Sigh) <img width="641" alt="Capture" src="https://user-images.githubusercontent.com/32636402/208161552-b7f2cce1-8cda-4aff-b806-10c8b8680f7b.PNG";> vs vertig0@LAPTOP-NEMLU0S6 UCRT64 ~ $ echo USER is :$USER: USER is :vertig0: Prior to the change the default was set pretty much after every other check, which is why it never caused a failure, but I am pretty surprised that the rest of the build was able to handle an empty name so well ------------- PR: https://git.openjdk.org/jdk/pull/11020
![https://user-images.githubusercontent.com/32636402/208161552-b7f2cce1-8cda-4aff-b806-10c8b8680f7b.PNG"](https://user-images.githubusercontent.com/32636402/208161552-b7f2cce1-8cda-4aff-b806-10c8b8680f7b.PNG"){kind=link}