On Thu, 9 Feb 2023 13:10:43 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java
> line 98:
>
>> 96: <T> T optionValue(Classfile.Option.Key option);
>> 97:
>> 98: boolean canWriteDirect(ConstantPool constantPool);
>
> Missing javadoc in these two methods.
Will fix it, thanks.
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java
> line 187:
>
>> 185: * {@return A {@link ModuleEntry} describing the module whose name
>> 186: * is encoded in the provided {@linkplain Utf8Entry}}
>> 187: * If a Module entry in the pool already describes this class,
>
> (Here and elsewhere) - Module is capitalized. Either you use a lower case
> name, or you use a capital name, to refer to `ModuleEntry`, or
> `CONSTANT_Module_info` - e.g. a standalone `Module` with capital `M` is not a
> concept in this API. (personally I think lower case is just fine).
Will fix it, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
