On Mon, 31 Jul 2023 04:52:35 GMT, Julian Waters <[email protected]> wrote:
>> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Try not to remove CCACHE_BASEDIR. > > make/common/NativeCompilation.gmk line 218: > >> 216: # dependency files to contain paths compatible with make. >> 217: # >> 218: ifeq ($(ALLOW_ABSOLUTE_PATHS_IN_OUTPUT), false) > > I would advise against doing so, since we don't yet know why this was done This part is no longer in the patch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1279192384
