On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil <jkratoch...@openjdk.org> wrote:
>> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust compatibility with FILE_MACRO_CFLAGS. I've left a code suggestion that hopefully fixes the issue of it not working. You can move the comment about ccache anywhere you want otherwise make/common/NativeCompilation.gmk line 231: > 229: endif > 230: > 231: ifdef NEED_FIX_DEPS_FILE Suggestion: ifeq ($(call Or, $(if $(CCACHE), true), $(call equals $(ALLOW_ABSOLUTE_PATHS_IN_OUTPUT), false))-$(FILE_MACRO_CFLAGS), true-) # CCACHE_BASEDIR needs fix-deps-file as makefiles use absolute filenames for # object files while CCACHE_BASEDIR will make ccache relativize all paths for # its compiler. The compiler then produces relative dependency files. # make does not know a relative and absolute filename is the same so it will # ignore such dependencies. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15080#issuecomment-1658165868 PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1279148929
