On Wed, 9 Aug 2023 12:17:14 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Jesse Glick has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Making `building.md` also link only to the guide >> - Linking only to the guide, as suggested by @JesperIRL: >> https://github.com/openjdk/jdk/pull/14716#issuecomment-1670908305 >> - Merge branch 'master' of https://github.com/openjdk/jdk into patch-1 >> - 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR > > doc/building.md line 2035: > >> 2033: you to follow our rules and guidelines to be able to accept your >> contribution. >> 2034: >> 2035: The official place to start is the [OpenJDK Developers’ >> Guide](https://openjdk.org/guide/). > > When changing this file, you also need to regenerate the `building.html`. See > bottom of this file for instructions. See https://github.com/openjdk/jdk/pull/14716#discussion_r1288389758. I am supposed to check in just the modified HTML paragraph? All the modifications to `building.html`, even those unrelated to the Markdown change? All the modifications to other HTML files, even those unrelated to this patch? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14716#discussion_r1288412572
