On Fri, 1 Sep 2023 21:08:53 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> Compiling the ADLC build tool on Windows is generating multiple warnings like > this: > > cl : Command line warning D9007 : '/pathmap:' requires > '/experimental:deterministic'; option ignored > > This is caused by the `ADLC_CFLAGS` are including `$FILE_MACRO_CFLAGS` but > missing `$REPRODUCIBLE_CFLAGS`. This patch simply adds them. At some point we > should refactor the ADLC flags properly, but I don't think we should wait for > that to fix these warnings. Looks good. I agree that ADLC flags needs to be sorted out properly at some time... ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15545#pullrequestreview-1635269376
