On Fri, 1 Sep 2023 21:08:53 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> Compiling the ADLC build tool on Windows is generating multiple warnings like > this: > > cl : Command line warning D9007 : '/pathmap:' requires > '/experimental:deterministic'; option ignored > > This is caused by the `ADLC_CFLAGS` are including `$FILE_MACRO_CFLAGS` but > missing `$REPRODUCIBLE_CFLAGS`. This patch simply adds them. At some point we > should refactor the ADLC flags properly, but I don't think we should wait for > that to fix these warnings. I'll add cleaning up the ADLC flags to my list of things to do. It's a shame that we can't add the deterministic setting to ADLC_CFLAGS without exporting it to spec.gmk.in though, in my opinion. In any case, have a complementary approval :) ------------- Marked as reviewed by jwaters (Committer). PR Review: https://git.openjdk.org/jdk/pull/15545#pullrequestreview-1608961803
