On Thu, 14 Sep 2023 03:23:55 GMT, Julian Waters <[email protected]> wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Document changes in awt_DnDDS.cpp
>
> Pinging
> @TheShermanTanker In my experience, getting reviews from all areas for issues
> like this that cuts through the entire JDK can be difficult. Another
> approach, which requires more work from your side, but hopefully less from
> the reviewers' (and thus makes it easier for them to review) is to split this
> PR into multiple ones: One for each area (basically, area == mailing list)
> that just makes the changes to the code necessary to (in the future) turn on
> /permissive-. And then finally a small "finishing" PR which just touches the
> makefile and enables the flag, when all code is fixed.
>
> As a side effect, it is also 100% clear that all parts of the code has been
> correctly reviewed, since then reviewers do not need to leave conditions on
> their reviews ("i only looked at the foo parts").
I understand, will split this into multiple changes after I answer all queries
above
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1730719188
