On Wed, 11 Oct 2023 21:50:10 GMT, Phil Race <p...@openjdk.org> wrote:
>> Mikael Vidstedt has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update stale comment (again) >> - Update stale comment > > Marked as reviewed by prr (Reviewer). > @prrace I noticed few deprecated constants being used in NSApplication.m > [#L336](https://github.com/openjdk/jdk/blob/b92de54a81a4037a5396509d41de57323212639c/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m#L336), > > [#L360](https://github.com/openjdk/jdk/blob/b92de54a81a4037a5396509d41de57323212639c/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m#L360) > such as https://developer.apple.com/documentation/appkit/nsappkitdefined. > > Now that macosx-x64 target version is being bumped to 11.x, do we change it > before the update? > > Previously few of the deprecated NSEvent constants which were part of > CocoaConstants.java file were changed as part of this > [PR#13435.](https://github.com/openjdk/jdk/pull/13435) Since 11.0 works fine for aarch64 I can't imagine its a problem for x64. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16155#issuecomment-1758597581
