On Wed, 11 Oct 2023 21:10:21 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This change updates the target version for macosx-x64 to 11.00.00, which is >> the same version used for macosx-aarch64. > > Mikael Vidstedt has updated the pull request incrementally with two > additional commits since the last revision: > > - Update stale comment (again) > - Update stale comment Other than that, it looks fine. Nice to be able to avoid platform-specific differences! make/modules/java.desktop/lib/Awt2dLibraries.gmk line 925: > 923: # should be used to compile Metal shaders. Metal uses the same minimum > 924: # version as the rest of the JDK. > 925: MACOSX_METAL_VERSION_MIN=$(MACOSX_VERSION_MIN) Actually, you can just inline `MACOSX_VERSION_MIN` in place; the only reason a separate variable was used was that it needed to take on different values depending on platform. ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16155#pullrequestreview-1673855439 PR Review Comment: https://git.openjdk.org/jdk/pull/16155#discussion_r1356636320
